KEP-1672: promote EndpointSliceTerminatingCondition feature to GA #3504

andrewsykim · 2022-09-12T19:07:03Z

Signed-off-by: Andrew Sy Kim andrewsy@google.com

One-line PR description:

Promote EndpointSliceTerminatingCondition feature gate to GA in v1.26. This feature has been Beta since v1.22 and was pending validation from sig-scalability on the performance implications of this change.

Issue link: Tracking Terminating Endpoints #1672

Other comments:

andrewsykim · 2022-09-12T19:07:49Z

keps/sig-network/1672-tracking-terminating-endpoints/kep.yaml

@@ -20,17 +20,18 @@ see-also:
 replaces: []

 # The target maturity stage in the current dev cycle for this KEP.
-stage: beta
+stage: stable


There's no diff in the actual KEP since it already includes the graudation criteria for GA:

#### GA * E2E tests validating that terminating pods are properly reflected in EndpointSlice API. * Ensure there are no performance/scalability regressions when enabling additional endpointslice writes for terminating endpoints. * This will be validated by running the existing scalability test suites where pods handle SIGTERM from kubelet before terminating. * All necessary metrics are in place to provide adequate observability and monitoring for this feature.

andrewsykim · 2022-09-12T19:11:43Z

keps/prod-readiness/sig-network/1672.yaml

@@ -3,3 +3,5 @@ alpha:
  approver: "@wojtek-t"
 beta:
  approver: "@wojtek-t"
+stable:
+  approver: "@wojtek-t"


@wojtek-t @marseel looking for a sign off here.

A few months back, myself and @marseel ran the Kubernetes performance tests to validate that this change did not regress performance significantly. IIRC, the tests included these two changes:

update sleep image to optionally handle SIGTERM perf-tests#1986

Update sleep image to 0.0.2 perf-tests#1987

I don't think we saw any noticeable regression in performance, but please correct me if I'm mis-remebering.

yes, you are correct, we haven't seen noticeable regression.

Yup - I remember that and I'm fine with this from scalability POV.
Some other comment below though :)

andrewsykim · 2022-09-12T23:30:56Z

/hold

We may want to consider promoting this to GA along with KEP-1669 (Beta promotion in #3505). Holding until we have agreement on whether we should promote these in lock-step or separately.

marseel · 2022-09-13T13:17:32Z

/lgtm
from sig-scalability perspective

andrewsykim · 2022-09-13T14:58:59Z

Thanks @marseel

/hold cancel

andrewsykim · 2022-09-13T14:59:50Z

/assign @thockin @robscott @wojtek-t

wojtek-t

I'm fine with this modulo the upgrade testing question that should have been updated before promoting to beta :)

wojtek-t · 2022-09-22T07:37:37Z

keps/prod-readiness/sig-network/1672.yaml

@@ -3,3 +3,5 @@ alpha:
  approver: "@wojtek-t"
 beta:
  approver: "@wojtek-t"
+stable:
+  approver: "@wojtek-t"


Yup - I remember that and I'm fine with this from scalability POV.
Some other comment below though :)

wojtek-t · 2022-09-22T07:39:49Z

keps/sig-network/1672-tracking-terminating-endpoints/kep.yaml


 # The milestone at which this feature was, or is targeted to be, at each stage.
 milestone:
  alpha: "v1.20"
  beta: "v1.22"
+  stable: "v1.26"


Comment regarding PRR in the KEP;

Not yet, but manual upgrade and rollback testing will be done prior to graduating the feature to Beta.

Have those been done? Can you please summarize the setup in which it was done and findings?
If not - can you please do that now?

Thanks, I added a new section for manual steps taken for testing rollback. Let me know if they are sufficient.

Yes - this looks great - thanks!

Signed-off-by: Andrew Sy Kim <andrewsy@google.com>

wojtek-t · 2022-09-23T06:55:17Z

/lgtm
/approve PRR

@andrewsykim - I'm holding this to ensure that you will add it to the tracking board:
https://github.com/orgs/kubernetes/projects/98/views/1
Feel free to cancel hold once it is added there.
/hold

wojtek-t · 2022-09-28T06:38:28Z

/hold cancel
This was added to tracking board.

@thockin - for SIG-level approval

sftim

How are we doing on documenting the new behavior?

thockin

From SIG side:

/lgtm
/approve

k8s-ci-robot · 2022-10-02T21:46:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, thockin, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~keps/prod-readiness/OWNERS~~ [wojtek-t]
~~keps/sig-network/OWNERS~~ [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andrewsykim · 2022-10-03T18:00:02Z

How are we doing on documenting the new behavior?

@sftim documentation was added here: kubernetes/website#25229, let me know if you think it needs more

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2022

k8s-ci-robot requested review from caseydavenport and thockin September 12, 2022 19:07

k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 12, 2022

andrewsykim commented Sep 12, 2022

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2022

k8s-ci-robot assigned marseel Sep 13, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2022

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2022

k8s-ci-robot assigned robscott, thockin and wojtek-t Sep 13, 2022

wojtek-t reviewed Sep 22, 2022

View reviewed changes

KEP-1672: promote EndpointSliceTerminatingCondition feature to GA

b8dda87

Signed-off-by: Andrew Sy Kim <andrewsy@google.com>

andrewsykim force-pushed the kep-1672 branch from a398b80 to 08fa9b8 Compare September 22, 2022 15:42

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 22, 2022

andrewsykim force-pushed the kep-1672 branch from 08fa9b8 to 55100d2 Compare September 22, 2022 15:44

KEP-1672: add manual validation done for upgrade/rollback testing

4d9dfe2

Signed-off-by: Andrew Sy Kim <andrewsy@google.com>

andrewsykim force-pushed the kep-1672 branch from 55100d2 to 4d9dfe2 Compare September 22, 2022 15:46

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2022

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2022

sftim reviewed Sep 29, 2022

View reviewed changes

thockin reviewed Oct 2, 2022

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2022

k8s-ci-robot merged commit e0f2894 into kubernetes:master Oct 2, 2022

k8s-ci-robot added this to the v1.26 milestone Oct 2, 2022

andrewsykim mentioned this pull request Oct 26, 2022

Promote EndpointSliceTerminatingCondition to GA kubernetes/kubernetes#113351

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KEP-1672: promote EndpointSliceTerminatingCondition feature to GA #3504

KEP-1672: promote EndpointSliceTerminatingCondition feature to GA #3504

andrewsykim commented Sep 12, 2022

andrewsykim Sep 12, 2022

andrewsykim Sep 12, 2022

marseel Sep 13, 2022

wojtek-t Sep 22, 2022

andrewsykim commented Sep 12, 2022

marseel commented Sep 13, 2022

andrewsykim commented Sep 13, 2022

andrewsykim commented Sep 13, 2022

wojtek-t left a comment

wojtek-t Sep 22, 2022

wojtek-t Sep 22, 2022

andrewsykim Sep 22, 2022

wojtek-t Sep 23, 2022

wojtek-t commented Sep 23, 2022

wojtek-t commented Sep 28, 2022

sftim left a comment

thockin left a comment

k8s-ci-robot commented Oct 2, 2022

andrewsykim commented Oct 3, 2022

KEP-1672: promote EndpointSliceTerminatingCondition feature to GA #3504

KEP-1672: promote EndpointSliceTerminatingCondition feature to GA #3504

Conversation

andrewsykim commented Sep 12, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewsykim commented Sep 12, 2022

marseel commented Sep 13, 2022

andrewsykim commented Sep 13, 2022

andrewsykim commented Sep 13, 2022

wojtek-t left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wojtek-t commented Sep 23, 2022

wojtek-t commented Sep 28, 2022

sftim left a comment

Choose a reason for hiding this comment

thockin left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 2, 2022

andrewsykim commented Oct 3, 2022